Przeglądaj źródła

test(omgpay): align payment controller coverage

qmj 2 tygodni temu
rodzic
commit
f46bf62190

+ 3 - 4
ruoyi-admin/src/test/java/com/ruoyi/app/omgpay/OmgLegacyRetirementTest.java

@@ -12,7 +12,7 @@ import static org.junit.jupiter.api.Assertions.*;
 
 class OmgLegacyRetirementTest {
     @Test
-    void oldRuntimeClassesAreAbsentAndNewControllerExposesOnlyCreateAndNotify() {
+    void oldRuntimeClassesAreAbsentAndNewControllerExposesSupportedPaymentOperations() {
         assertThrows(ClassNotFoundException.class, () -> Class.forName("com.ruoyi.app.pay.OmgPayController"));
         assertThrows(ClassNotFoundException.class, () -> Class.forName("com.ruoyi.app.task.OmgReconcileTask"));
         assertThrows(ClassNotFoundException.class, () -> Class.forName("com.ruoyi.system.domain.PosOrderOmgPayment"));
@@ -21,10 +21,9 @@ class OmgLegacyRetirementTest {
                 .filter(method -> method.isAnnotationPresent(PostMapping.class))
                 .flatMap(method -> Arrays.stream(method.getAnnotation(PostMapping.class).value()))
                 .collect(Collectors.toSet());
-        assertEquals(Set.of("/create", "/notify"), postPaths);
+        assertEquals(Set.of("/create", "/notify", "/query", "/refund"), postPaths);
         assertTrue(Arrays.stream(OmgPaymentController.class.getDeclaredMethods())
                 .map(method -> method.getName().toLowerCase())
-                .noneMatch(name -> name.contains("query") || name.contains("paymentinfo")
-                        || name.contains("return") || name.contains("refund")));
+                .noneMatch(name -> name.contains("paymentinfo") || name.contains("return")));
     }
 }

+ 7 - 2
ruoyi-admin/src/test/java/com/ruoyi/app/omgpay/OmgPaymentQueryControllerTest.java

@@ -39,7 +39,11 @@ class OmgPaymentQueryControllerTest {
         OmgQueryPaymentRequest request = new OmgQueryPaymentRequest();
         request.setOrderId("DD-1");
 
-        AjaxResult result = controller.query("token", request);
+        AjaxResult result;
+        try (MockedStatic<MessageUtils> messages = mockStatic(MessageUtils.class)) {
+            messages.when(() -> MessageUtils.message(anyString())).thenAnswer(call -> call.getArgument(0));
+            result = controller.query("token", request);
+        }
 
         assertSame(response, result.get("data"));
     }
@@ -61,7 +65,8 @@ class OmgPaymentQueryControllerTest {
             assertEquals("PAYMENT_QUERY_NOT_AVAILABLE",
                     ((OmgPaymentErrorResponse) business.get("data")).status());
 
-            when(queryService.query(5L, "DD-1")).thenThrow(new IllegalStateException("gateway down"));
+            doThrow(new IllegalStateException("gateway down"))
+                    .when(queryService).query(5L, "DD-1");
             AjaxResult unexpected = controller.query("token", request);
             assertEquals("PAYMENT_QUERY_FAILED",
                     ((OmgPaymentErrorResponse) unexpected.get("data")).status());